Add sysconfig support for sysv #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solarkennedy
added a commit
that referenced
this pull request
Oct 23, 2014
Add sysconfig support for sysv
|
Yea, I saw we were not managing GOMAXPROCS the other day when I was looking at some upstream init stuff. I disagree on managing the file. Managing the configuration of consul is definitely within the scope of this module. |
|
Ok, fair enough :) Managing the sysconfig file would be fine. One of the main reasons I didn't is because I wasn't sure how you would handle separating that out since other OS's/init systems won't use that. |
|
This module is already managing the init scripts, so we could ensure all the flavors of init script |
|
@EvanKrall that actually sounds like a great idea. With that in place we could make all the init scripts flat files and not have the template stuff to worry about - manage all via defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source
/etc/sysconfig/consul, if present. This will allow users to overridePID_FILEorLOG_FILEif they wish. Also, it will allow setting GOMAXPROCS. This is maybe the most important feature this provides because otherwise GOMAXPROCS defaults to 1, which is not recommended. If the user does not set GOMAXPROCS after this change, it will default to 2.I don't believe managing
/etc/sysconfig/consulis necessary within this module. It's not a required file for this to work and users can optionally manage that file in a profile or wrapper module.